Ignore SIGINT and SIGQUIT in non-interactive background processes #6861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ridiculousfish
approved these changes
Apr 5, 2020
There was a problem hiding this comment.
In addition to the new test (which is great), in 866d506 I added a fish_test_helper command to print blocked signals, that would be an easy littlecheck test to write.
> status job-control none
> fish_test_helper print_blocked_signals
Interrupt: 2
Quit: 3
src/exec.cpp
Outdated
| /// Call fork() as part of executing a process \p p in a job \j. Execute \p child_action in the | ||
| /// context of the child. Returns true if fork succeeded, false if fork failed. | ||
| static bool fork_child_for_process(const std::shared_ptr<job_t> &job, process_t *p, | ||
| const dup2_list_t &dup2s, const char *fork_type, | ||
| const std::function<void()> &child_action) { | ||
| pid_t pid = execute_fork(); | ||
| if (pid == 0) { | ||
| sigset_t sigmask; |
There was a problem hiding this comment.
Let's unify signal manipulation under child_setup_process - see the call to signal_reset_handlers. I think you can probably just replace that call outright with one that sets a sigmask, which you compute.
CHANGELOG.md
Outdated
| @@ -4,6 +4,7 @@ | |||
| - `fish --no-execute` will no longer complain about unknown commands or non-matching wildcards, as these could be defined differently at runtime (especially for functions). #977 | |||
| - `jobs --quiet PID` will no longer print 'no suitable job' if the job for PID does not exist (e.g. because it has finished). #6809 | |||
| - A variable `fish_kill_signal` will be set to the signal that terminated the last foreground job, or `0` if the job exited normally. | |||
| - Control-C no longer kills background jobs started in config.fish (#6828). | |||
There was a problem hiding this comment.
Let's also say what the underlying change here is, and why (to match POSIX).
krobelus
force-pushed
the
background-job-mask-signals
branch
2 times, most recently
from
04be846
to
7305929
Compare
Otherwise it would print "Unknown Signal" on Linux. I didn't see an obvious way to check signal validity, plus it hardly matters. Also mimic the output from BSD strsignal on Linux.
krobelus
force-pushed
the
background-job-mask-signals
branch
from
7305929
to
db99c72
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6828
TODOs: